I noticed after the merge that I had neutered the if block for the MSVC_CPU_ARCH option in such a way that it was only effective for x86 builds, not x86-64 builds. This also lead to a warning message when building for 64-bit. So the artifact of the old if block was cleaned up, making it effective for both 32-bit and 64-bit builds, and getting rid of that warning.
Additionally, since avs_core can compile with -std=c++17 without needing the use of the GNU extensions, it makes sense to disable those and bring it closer into conformance like MSVC now is (as a side-note, DirectShowSource now fails to build in MSVC because of the stricter conformance; seems like it was probably the only thing left that still needed the permissive flag set).
Lastly, the FFmpeg-devel mailing list mentioned a typo in avisynth_c.h a couple months ago, so¹ I went through it with aspell and corrected those, plus as many other spelling or grammatical things that I could find (the other three headers FFmpeg uses - capi.h, config.h, and types.h - had no issues in this area).
¹because with the addition of the AVSC_WIN32_GCC32 define and the other structural updates to the header, the one FFmpeg ships locally needed to be updated as well. Might as well get the typo fixes out of the way while I was at it.
I noticed after the merge that I had neutered the if block for the MSVC_CPU_ARCH option in such a way that it was only effective for x86 builds, not x86-64 builds. This also lead to a warning message when building for 64-bit. So the artifact of the old if block was cleaned up, making it effective for both 32-bit and 64-bit builds, and getting rid of that warning.
Additionally, since avs_core can compile with -std=c++17 without needing the use of the GNU extensions, it makes sense to disable those and bring it closer into conformance like MSVC now is (as a side-note, DirectShowSource now fails to build in MSVC because of the stricter conformance; seems like it was probably the only thing left that still needed the permissive flag set).
Lastly, the FFmpeg-devel mailing list mentioned a typo in avisynth_c.h a couple months ago, so¹ I went through it with aspell and corrected those, plus as many other spelling or grammatical things that I could find (the other three headers FFmpeg uses - capi.h, config.h, and types.h - had no issues in this area).
¹because with the addition of the AVSC_WIN32_GCC32 define and the other structural updates to the header, the one FFmpeg ships locally needed to be updated as well. Might as well get the typo fixes out of the way while I was at it.