search

pinterf / Frfun7

Frfun7 is a spatial denoising plugin for Avisynth
GNU General Public License v2.0
17 stars 0 forks source link

Slowdown when p=1 and TP1 is defined. #4

Open Reel-Deal opened 1 year ago

Reel-Deal commented 1 year ago

Hi there pinterf, I noticed something odd. Whenever p=1 and tp1 is defined there is a massive slowdown. For example:

ColorBars(pixel_type="YV12")
frfun7(lambda=1.01, T=8.0, P=1) #, TP1=0) # around 50 fps when commented out and ~4fps when not.

What makes it more odd is that the default for TP1 is 0. Using latest version with avs+ test7.

Edit: P=1 and TP1=0 seems to be the problem. TP1=1 or greater is fast again and it only gets faster the higher you go.

pinterf commented 1 year ago

I don't understand that part what it really does, but it is sure that when TP1 (here as P1_param) is zero, the 'continue' will never happen. https://github.com/pinterf/Frfun7/blob/main/Frfun7/Frfun7.cpp#L1907 The processing will always go on to the rest of the loop code. The frcore_dev_2x_b4 and frcore_filter_overlap_b4r2_simd are really time consuming operations.