search

pinterf / TIVTC

TIVTC and TDeint
57 stars 9 forks source link

d.blockx may not be set #13

Closed 299792458m closed 4 years ago

299792458m commented 4 years ago

aren't they to set blockx? https://github.com/pinterf/TIVTC/blob/0464aa7a98faf9967d830b0b52f1d0176aa0042a/src/TIVTC/FrameDiff.cpp#L364 https://github.com/pinterf/TIVTC/blob/0464aa7a98faf9967d830b0b52f1d0176aa0042a/src/TIVTC/TDecimate.cpp#L1006 https://github.com/pinterf/TIVTC/blob/0464aa7a98faf9967d830b0b52f1d0176aa0042a/src/TIVTC/TDecimate.cpp#L1146

pinterf commented 4 years ago

Of course it's wrong! Thanks for pointing out on that! I'm not at my PC, which modes did it affect?

pinterf commented 4 years ago

Fixed in v1.0.21

299792458m commented 4 years ago

thanks. I noticed because the calcDiff_SADorSSD_32x32_SSE2 function wasn't used. But if I fixed that blockx, the result become changed. So, I confused what was right..

and maybe jist typo xsubsampling == 2? https://github.com/pinterf/TIVTC/blob/ca38bab0afc044aadf6670a1f551b50395dfb641/src/TIVTC/TDecimateASM.cpp#L1095

pinterf commented 4 years ago

YV411: Yep, another good catch, thanks. Fixed. (I'm not making a release from that yet).

299792458m commented 4 years ago

I found why result was changed when Using calcDiff_SADorSSD_32x32_SSE2. These lines are not needed... https://github.com/pinterf/TIVTC/blob/7f216e76c2bcecbf78836d6ad880edf951285c2f/src/TIVTC/TDecimateASM.cpp#L326 https://github.com/pinterf/TIVTC/blob/7f216e76c2bcecbf78836d6ad880edf951285c2f/src/TIVTC/TDecimateASM.cpp#L327

pinterf commented 4 years ago

Thank you, I'll incorporate them soon and this one really deserves a fixed release.

299792458m commented 4 years ago

Thanks!

pinterf commented 4 years ago

Thanks for the contribution, I hope not much other bugs left after the huge code reorganizations.