pinterf / masktools

MaskTools v2 fork
Other
48 stars 11 forks source link

new floatUV for scale_inputs, clamp_float now int instead of bool, new yrange_max, yrange_half and yrange_min #6

Closed realfinder closed 5 years ago

pinterf commented 5 years ago

Making clamp_float as int instead of bool: doesn't it break all scripts which were already using this parameter? If so, it's a no-go. Neither here nor at a possible Avisynth Expr update.

realfinder commented 5 years ago

Making clamp_float as int instead of bool: doesn't it break all scripts which were already using this parameter? If so, it's a no-go. Neither here nor at a possible Avisynth Expr update.

it will break them but it's not a problem since I will update all scripts after that, most if not all avs scripts updates done by me anyway

realfinder commented 5 years ago

and if you still care for not breaking scripts then new bool clamp_float_stuv or something is needed, when it's true (default) will be standard clamp, and when it's false will mean chroma UV clamp same as luma 0..1 and of course clamp_float_stuv will do nothing if clamp_float=false

feel free to chose the appropriate names of parameters :)

pinterf commented 5 years ago

O.K. I'm merging and look into what I can do with the names. When we speak about compatibility and whether it breaks something or not: we cannot assume that everybody is following your doom9 page for scripts or git, sometimes even myself have problems on fonding the latest version of your scripts. Then there is a case when someone is using a ready-to-use framework where plugins/script are bundled and just looks into new versions of some key plugins. And we cannot forget those silent ones who are just using and writing masktools and Avisynth+ on their own.

pinterf commented 5 years ago

(info: though it is not written, project is using spaces instead of tab characters in the source code)

realfinder commented 5 years ago

This explain why my changes was odd when I upload them in github

pinterf commented 5 years ago

Status: I'm working on the avs+ side, probably I'll put back the type-changed parameter to bool and introduce a new one.

realfinder commented 5 years ago

that good

after thinking, yes it's better to keep it bool not only for people who don't update but also for testing with older avs+/masktools easily

realfinder commented 4 years ago

so, for now, what left for this updates? put back the type-changed parameter of clamp_float to bool and introduce a new one like clamp_float_stuv? and then port all that to avs+ expr?

pinterf commented 4 years ago

Yes, my Expr modification is now using a new bool parameter called clamp_float_uv. So now it's a bit ahead of masktools { "Expr", BUILTIN_FUNC_PREFIX, "c+s+[format]s[optAvx2]b[optSingleMode]b[optSSE2]b[scale_inputs]s[clamp_float]b[clamp_float_UV]b", Exprfilter::Create },