search

pinterf / xy-VSFilter

xy-VSFilter
GNU General Public License v2.0
547 stars 22 forks source link

Aren't you going to release a new version? #45

Open Hackjjang opened 1 year ago

Hackjjang commented 1 year ago

It's a shame that the code update hasn't been released for almost half a year, as it seems to be going well. I'm using it on MPC-HC or MPC-BE, but I'd like to try the new modified one.

pinterf commented 1 year ago

Hi, due to being busy in other areas of life I'm not following the project closely, and I'm not even aware that it is still used by people.

On the other hand, since there was some activity again in the original repo (see https://github.com/Cyberbeing/xy-VSFilter/commits/xy_sub_filter_rc5), which I considered to be dead years ago (as it was indeed dead at that time), I guessed my repo was no longer valid, though I think it contains modifications which do not exist there.

Potmarigold commented 1 year ago

Is it possible for you to keep improving xy-VSFilter since the subtitle feature of MPC-BE is not very good?

A lot of people use xy-VSFilter because the subtitle function on MPC-BE is so poor.

astiob commented 10 months ago

On the other hand, since there was some activity again in the original repo (see https://github.com/Cyberbeing/xy-VSFilter/commits/xy_sub_filter_rc5), which I considered to be dead years ago (as it was indeed dead at that time), I guessed my repo was no longer valid, though I think it contains modifications which do not exist there.

To clarify, it seems Cyberbeing checked on the open pull requests briefly but was too busy to return to active maintenance personally. He did give write access to Oneric and me, though.

Of the several PRs he merged himself, one was (intentionally) exactly mirrored in this repo. The other few though, I don’t know. @Masaiki, are those just mirrors/ports of code that’s already in pinterf’s fork, or is something new included as well?

If you feel that you no longer have the energy to maintain VSFilter actively either, one possible course of action is to merge the two repos into one. Since we have write access now, it can be Cyberbeing’s if you feel that’s more appropriate. Otherwise, you’ll probably want to merge the few new changes from Cyberbeing’s repo here.

Masaiki commented 10 months ago

are those just mirrors/ports of code that’s already in pinterf’s fork, or is something new included as well?

@astiob https://github.com/Cyberbeing/xy-VSFilter/pull/22 & https://github.com/Cyberbeing/xy-VSFilter/pull/21 from https://github.com/Masaiki/xy-VSFilter https://github.com/Cyberbeing/xy-VSFilter/pull/20 from VSFilter in MPC-BE

astiob commented 10 months ago

I’ll take that as “they’re not in pinterf’s fork”.

pinterf commented 10 months ago

Sure, I have no energy - and active knowledge - for the project maintenance, but merging a finite number of changes is probably not a big task. I can give write access as well, which is better and quicker for the community.

TheOneric commented 9 months ago

Backported most of the recent changes in #46

pinterf commented 8 months ago

Thank you for your work. https://github.com/pinterf/xy-VSFilter/releases/tag/3.2.0.809