search

pion / .goassets

Asset files automatically deployed to Go package repositories
https://pion.ly/
MIT License
9 stars 10 forks source link

Allow single line commit messages #143

Closed stv0g closed 1 year ago

stv0g commented 1 year ago

Its one of the major reasons new contributions are failing the CI for..

ashellunts commented 1 year ago

I support the suggestion.

at-wat commented 1 year ago

I basically second this, but we also should check commits just saying Bug fix on review

Sean-Der commented 1 year ago

I support as well! Could we switch to https://www.conventionalcommits.org/en/v1.0.0/ ?

Then we could also generate nice CHANGELOGs. Users want to know what is in a new commit (bugs, features etc..)

stv0g commented 1 year ago

I like the idea of the conventional commits spec. Especially, because we could get rid of our own script to validate the commit messages.

ashellunts commented 1 year ago

I have found this go tool (https://github.com/aevea/commitsar) to check for conventional commit compliance. Pro: it has GitHub actions support. Con: dependency to install when running locally.

How are we going to handle renovate bot commit messages that are not compliant with conventional commit style?

at-wat commented 1 year ago

How are we going to handle renovate bot commit messages that are not compliant with conventional commit style?

Renovate supports conventional commit message https://docs.renovatebot.com/semantic-commits/