search

pion / .goassets

Asset files automatically deployed to Go package repositories
https://pion.ly/
MIT License
8 stars 10 forks source link

Rewrite shell scripts in Go #163

Open stv0g opened 1 year ago

stv0g commented 1 year ago

I think we could try to rewrite our Bash-based linting scripts in Go.

WDYT?

kehiy commented 10 months ago

@stv0g for getting this issue done. is there any thing to be considered? or just rewrite them in go?

Sean-Der commented 10 months ago

@kehiy nothing to consider! As long as they behave the same we are good to go :)

happy to help with testing/reviews

kehiy commented 10 months ago

@Sean-Der okay, so I start work on this issue

stv0g commented 10 months ago

I agree with Sean here. Maybe we start with a single script per PR?

kehiy commented 10 months ago

@stv0g that's a good point I will rewrite them one by one.

Sean-Der commented 10 months ago

Merged! Thank you @kehiy

Keep up the great work. Would love to see those all merged (and this issue resolved)

kehiy commented 10 months ago

@Sean-Der thank you so much. yeap! I will fix them one by one...