search

pion / .goassets

Asset files automatically deployed to Go package repositories
https://pion.ly/
MIT License
8 stars 10 forks source link

Add file name lint go script #176

Closed kehiy closed 9 months ago

kehiy commented 10 months ago

Description

rewrite the lint file name script in Golang.

Reference issue

kehiy commented 10 months ago

@Sean-Der can you have a review?

kehiy commented 10 months ago

@stv0g @Sean-Der is that okay now?

stv0g commented 10 months ago

@kehiy It seems like you have resolved my previous review comments without addressing them?

Please also not that the CI is currently failing. We can only merge it once all the checks are passing.

Thanks for your support :)

kehiy commented 10 months ago

@stv0g what so you mean addressing them? about ci I tried to fix them but its true we can merge it

stv0g commented 10 months ago

@stv0g what so you mean addressing them?

I've proposed changes which you have ignored and marked the corresponding threads as resolved. I have now went ahead an unresolved them. Please commit the suggested changes.

kehiy commented 10 months ago

@stv0g what so you mean addressing them?

I've proposed changes which you have ignored and marked the corresponding threads as resolved. I have now went ahead an unresolved them. Please commit the suggested changes.

oh, yeas I can see, but I committed the suggestions on GitHub directly! I will try to do it againg.

kehiy commented 10 months ago

@stv0g I think its ok now Is that?

stv0g commented 10 months ago

Okay cool :) It looks alright now 👍🏻

You would only need to fix the CI pipeline. Here are some tips:

  1. Add the same SPDX headers to the go.mod mod file in the beginning
  2. Add your name + email (Kay <kehiiiiya@gmail.com>) to the AUTHORS.txt file. Make sure the entry is at the correct place (alphabetically ordered)
  3. Squash all your commits and give it a correct commit message.
kehiy commented 9 months ago

@stv0g Everything is fixed just for squashing the commits I got a lot of errors and conflicts, and I think it's better to squash them when you want to merge them on GitHub.

stv0g commented 9 months ago

Hi, you can also squash lically. I added a link about it in my previous comment

kehiy commented 9 months ago

okay, I tried to do this locally, but I will try again.

kehiy commented 9 months ago

@stv0g can you have a review?