pion / .goassets

Asset files automatically deployed to Go package repositories
https://pion.ly/
MIT License
9 stars 10 forks source link

Remove AUTHORS.txt #185

Closed Sean-Der closed 9 months ago

Sean-Der commented 9 months ago

golang removed it https://github.com/golang/go/issues/53961

This just removes complexity/makes contributing a little easier.

Yay/Nay @at-wat @stv0g @daenney ?

stv0g commented 9 months ago

👍

daenney commented 9 months ago

:shipit:

enobufs commented 9 months ago

+1

./scripts/generate-authors.sh appears to have some issue too. Local pre-push update AUTHORS.txt like this and confused me a bit.

% git diff
diff --git a/AUTHORS.txt b/AUTHORS.txt
index 46ee72e..15594a2 100644
--- a/AUTHORS.txt
+++ b/AUTHORS.txt
@@ -3,6 +3,7 @@
 #
 # This file is auto generated, using git to list all individuals contributors.
 # see https://github.com/pion/.goassets/blob/master/scripts/generate-authors.sh for the scripting
+ Will Forcey <wsforc3y@gmail.com>
 Aaron France <aaron.l.france@gmail.com>
 Adrian Cable <adrian.cable@gmail.com>
 Atsushi Watanabe <atsushi.w@ieee.org>

I'd rather remove AUTHORS.txt than fixing it. (Less work/confusion for contributors!)

Sean-Der commented 9 months ago

@enobufs confused me also :) that is what led me down this journey!

all the authors are in the git history, so I hope that makes people feel good still. Not hard to go back if we need though!