search

pion / .goassets

Asset files automatically deployed to Go package repositories
https://pion.ly/
MIT License
9 stars 10 forks source link

#196 introduced a lot of new lint errors #201

Closed at-wat closed 6 months ago

at-wat commented 7 months ago

196 seems introduced a lot of new lint errors:

https://github.com/pion/webrtc/actions/runs/8089732277/job/22106111066?pr=2685#step:5:25

  Running [/home/runner/golangci-lint-1.56.2-linux-amd64/golangci-lint run --out-format=github-actions $GOLANGCI_LINT_EXRA_ARGS] in [] ...
  Warning: unused-parameter: parameter 'headPacket' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'o' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'receiver' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'receiver' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'receiver' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'id' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'track' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'track' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'track' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'attributes' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'pair' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'cs' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'ss' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'pcs' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'ics' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'trackRemote' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'midValue' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'm' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'p' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'd' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
  Warning: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)

  Error: issues found
  Ran golangci-lint in 33923ms

Originally posted by @at-wat in https://github.com/pion/.goassets/issues/196#issuecomment-1970244240

Sean-Der commented 7 months ago

:+1: I will go and disable these linters!

The issue was that golangci-lint wasn't working with newer versions of Go

Sean-Der commented 6 months ago

I have fixed the code across all repos, thanks for filing this @at-wat