search

pion / .goassets

Asset files automatically deployed to Go package repositories
https://pion.ly/
MIT License
8 stars 10 forks source link

Blacklist usage of testify/assert #206

Open Sean-Der opened 3 months ago

Sean-Der commented 3 months ago

What do you think of requiring require everywhere @stv0g

I am merging your change that does this in pion/ice, seems like a good idea to be consistent!

stv0g commented 3 months ago

Hey @Sean-Der,

I am not so sure about it as its not always desired to immediatly abort a test. Sometimes we are doing table-like tests in a single test using loops to test various combination of parameters. If we would use require in this case, we would abort the parametrized test case on the first failing parameter combination.

Sean-Der commented 3 months ago

What about allowing the lint to be disabled on a line basis?

I am taking a bunch of your ice improvement. Would love to see them propagate out across all the repos and be consistent