CI: Convert to github actions - Githubissues

pion / .goassets

Asset files automatically deployed to Go package repositories

https://pion.ly/

MIT License

9 stars 10 forks source link

CI: Convert to github actions #39

Closed tarrencev closed 3 years ago

tarrencev commented 3 years ago

converts travis tasks to github actions

Sean-Der commented 3 years ago

LGTM! Updating the golangci-lint version is adventurous, but I am happy to help :)

at-wat commented 3 years ago

Using GitHub Actions would be basically nice, but I have a few concerns

Concurrency of Travis CI is limited by 5/repository, but GitHub Actions is limited by 20/account https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits
- I'm not very sure how 20 jobs/account affects. Let's see what happens on pion.
Push by GitHub Actions don't triggers another GitHub Actions, so CI won't run when go-sum-fix-action pushes fix of go.sum
- We should add a personal access token to all of our repositories and replace the token used by go-sum-fix-action https://github.com/pion/.goassets/blob/7cb67f82fb077ca0d8807a11b7e9e7fada4b2c9d/ci/.github/workflows/renovate-go-mod-fix.yaml#L31

at-wat commented 3 years ago

Not very critical, but one downside of GitHub Actions for me is that GitHub Actions cancels all other jobs in the matrix build immediately if one fails. So, we can't see whether the PR is failing only on the specific version or broken on all versions.

tarrencev commented 3 years ago

I personally am ok with those tradeoffs. It seems Github actions runs significantly faster. So effective concurrency is likely higher than Travis CI. Github actions are also provide a much more user friendly integration and are easier to understand. But up to you guys how we'd like to go forward.

at-wat commented 3 years ago

I feel OK too with GitHub Actions! But access token for go-sum-fix-action should be added in near future, otherwise we can't see CI result of some renovate PRs.

at-wat commented 3 years ago

But access token for go-sum-fix-action should be added in near future, otherwise we can't see CI result of some renovate PRs.

@Sean-Der FYI

Sean-Der commented 3 years ago

@at-wat :+1: thanks for calling that out, didn't realize that.

Is this the access token for Pionbot? If you wouldn't mind sending it to me I can get that into all the repos!

at-wat commented 3 years ago

@Sean-Der sorry, I had forgotten to share the account of Pionbot. WIll DM soon.

tarrencev commented 3 years ago

@Sean-Der @at-wat i think we can create an organization level secret (iirc)