Sync Travis-CI configs - Githubissues

pion / .goassets

Asset files automatically deployed to Go package repositories

https://pion.ly/

MIT License

9 stars 10 forks source link

Sync Travis-CI configs #4

Closed at-wat closed 4 years ago

at-wat commented 4 years ago

Common CI setting for the latest ~one~ two Go versions.

Sean-Der commented 4 years ago

We might be able to cover all repos now! https://stackoverflow.com/a/54919732 it looks like having to fetch Go just for WASM might not be true (just misconfigured path)

If we can setup a build matrix to do i386 + ARM + x64 for test (but x64 only for lint) I think that should cover everything.

Sean-Der commented 4 years ago

We might not need to split for lint+test! If we can get everything standardized long term I think we will be in a much better spot.

I will see if I can pion/webrtc to not need its customization. It is the only repo I am aware of that does extra stuff.

at-wat commented 4 years ago

Sounds great! A few repos are also excluded temporary.

~webrtc: having test with Node.js, WASM build, i386 build~
- added i386 test to the common .travis.yml.
- added WASM test.
~turn: golang-ci version is 1.19.1 which has some extra linter which fails on some other repos~
- Use 1.19.1 and disable new linters by .golangci.yml per repository until the repository addresses them.
~dtls: trying to test on the latest two Go version: https://github.com/pion/dtls/pull/159~
- now the common .travis.yml contains test on the latest two Go versions.
- like: https://travis-ci.org/pion/quic/builds/635547732

Feel free to add commits to this branch.

at-wat commented 4 years ago

turn: golang-ci version is 1.19.1 which has some extra linter which fails on some other repos

It might be better to just move to 1.19 and disable new linters by .golangci.yml per repository until the repository addresses them.

at-wat commented 4 years ago

Fixing wasm test at https://github.com/pion/quic/pull/16

at-wat commented 4 years ago

webrtc pkg requires wrtc package. Need to setup hook in go_js_wasm_exec.

at-wat commented 4 years ago

I tried to use wasmbrowsertest and Chrome to remove test dependency to wrtc. Test works fine, but browser can't output coverage report. https://github.com/pion/webrtc/pull/973

at-wat commented 4 years ago

Running tests for WASM on all repos looks messy as WASM is still in Minimum Viable Product stage. e.g. IP socket is not yet supported and net_fake.go is used in Go1.13. A lot of the tests using net.Conn fail to be built, deadlock, or cause runtime error due to a bug in net_fake.go.

panic: interface conversion: net.sockaddr is *net.UDPAddr, not *net.TCPAddr

(dtls, ice, sctp, transport, turn, webrtc fail)

at-wat commented 4 years ago

It should be ready after merging WASM fix PRs.

daenney commented 4 years ago

I've gone ahead and approved them all, since they were just a build tag.

at-wat commented 4 years ago

commit from github web ui looks using CR+LF.

at-wat commented 4 years ago

Merging now. Will try syncing to the repos.