search

pion / .goassets

Asset files automatically deployed to Go package repositories
https://pion.ly/
MIT License
9 stars 10 forks source link

lint-commit-message.sh is not working on GitHub Actions #47

Closed at-wat closed 3 years ago

at-wat commented 3 years ago

The script requires TRAVIS_COMMIT_RANGE environment variable.

https://github.com/pion/.goassets/blob/326ae6400391dd6611743cc755e7c45983e6f755/.github/workflows/lint.yml#L23-L35 Above hack emulates TRAVIS_COMMIT_RANGE environment variable. (I'm not very sure it covers all situations.)

at-wat commented 3 years ago

FYI @Sean-Der @tarrencev

Sean-Der commented 3 years ago

Fixed with c162720a234ce5d083cb1de4af7e8d658735830f

Thanks for catching this @at-wat :)