search

pion / .goassets

Asset files automatically deployed to Go package repositories
https://pion.ly/
MIT License
8 stars 10 forks source link

Use gotestfmt for better output in Actions #83

Closed daenney closed 2 years ago

daenney commented 2 years ago

gotestfmt results in much more readable output in GitHub Actions than just running go test.

daenney commented 2 years ago

I've been trying to figure out if we really still need go-acc, and I can't get to an answer. Based on what I'm seeing, I think with current versions of the Go toolchain a regular go test ./... with the necessary coverage flags does what we expect and will correctly accumulate coverage over all packages.

Sean-Der commented 2 years ago

nice!

re: coverage I say we deploy this and just look at every repo, if coverage doesn't change then we are golden :)

daenney commented 2 years ago

OK, so looking at https://github.com/pion/ci-sandbox/actions/runs/2159882756 it seems we need to interpolate matrix.go into the test-log output or we only end up with the logs of one of the two being uploaded. Artifacts aren't scoped to the matrix, which I guess makes sense.

daenney commented 2 years ago

It does look a lot nicer now: https://github.com/pion/ci-sandbox/runs/6003734420?check_suite_focus=true#step:6:15