Add a new linting script to check that log output does not include trailing newlines

pion / .goassets

Asset files automatically deployed to Go package repositories

https://pion.ly/

MIT License

8 stars 10 forks source link

Add a new linting script to check that log output does not include trailing newlines #88

Closed stv0g closed 2 years ago

stv0g commented 2 years ago

The default logger implementation used by Pion uses the 'log' package from the standard library which normatlizes the newline endings. However as Pion allows users to provide a custom logger implementation which might not perform normaliaztion. Hence this linting script ensures that the all log outputs do not inlude trailing newlines.

stv0g commented 2 years ago

Just a little note: The grep regex currently assumes that the format string is a single string literal using double quotes. String concatenations or backquote literals or variables are not checked.

Sean-Der commented 2 years ago

Fantastic work @stv0g

I also added you to the Pion organization so your jobs will just run in the future.