pion / dtls

DTLS 1.2 Server/Client implementation for Go
https://pion.ly/
MIT License
603 stars 160 forks source link

Remove extraneous error checks in handshaker #553

Closed hasheddan closed 1 year ago

hasheddan commented 1 year ago

Description

Removes extraneous checks for flight error after alert error occurs. If we are sending alert then we already know that a flight error occurred.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.04 :tada:

Comparison is base (4fc3d8f) 76.34% compared to head (1f1570c) 76.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #553 +/- ## ========================================== + Coverage 76.34% 76.39% +0.04% ========================================== Files 95 95 Lines 5674 5672 -2 ========================================== + Hits 4332 4333 +1 + Misses 1001 998 -3 Partials 341 341 ``` | Flag | Coverage Δ | | |---|---|---| | go | `76.41% <0.00%> (+0.04%)` | :arrow_up: | | wasm | `66.44% <0.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/pion/dtls/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [handshaker.go](https://app.codecov.io/gh/pion/dtls/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#diff-aGFuZHNoYWtlci5nbw==) | `76.79% <0.00%> (+0.83%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/pion/dtls/pull/553/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.