pion / dtls

DTLS 1.2 Server/Client implementation for Go
https://pion.ly/
MIT License
604 stars 158 forks source link

flight3: respect curves configuration #588

Closed Snawoot closed 5 months ago

Snawoot commented 1 year ago

Description

As far as I understand Flight3 is pretty much like Flight1, but with Cookie. So I just reuse logic from Flight1 to ensure correct behaviour.

Reference issue

Fixes #587

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.13%. Comparing base (61b3466) to head (8bf6f8c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #588 +/- ## ========================================== + Coverage 80.07% 80.13% +0.05% ========================================== Files 101 101 Lines 5330 5330 ========================================== + Hits 4268 4271 +3 + Misses 687 684 -3 Partials 375 375 ``` | [Flag](https://app.codecov.io/gh/pion/dtls/pull/588/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/dtls/pull/588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `80.16% <100.00%> (+0.05%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/dtls/pull/588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `63.90% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

at-wat commented 6 months ago

Seems related to https://github.com/pion/dtls/pull/475 (@daenney FYI)

@Snawoot Could you add a test as well as flight1?

Sean-Der commented 5 months ago

I added a test, after CI passes will merge!