pion / dtls

DTLS 1.2 Server/Client implementation for Go
https://pion.ly/
MIT License
602 stars 160 forks source link

Fix flight1parse processing exception #600

Closed minlp closed 10 months ago

minlp commented 11 months ago

Description

Fix flight1parse processing exception

Reference issue

Fixes #... https://github.com/pion/webrtc/issues/2629

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ba72fba) 77.76% compared to head (46f9979) 77.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #600 +/- ## ========================================== + Coverage 77.76% 77.91% +0.15% ========================================== Files 101 101 Lines 6439 6444 +5 ========================================== + Hits 5007 5021 +14 + Misses 1056 1050 -6 + Partials 376 373 -3 ``` | [Flag](https://app.codecov.io/gh/pion/dtls/pull/600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/dtls/pull/600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `77.94% <100.00%> (+0.15%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/dtls/pull/600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `63.27% <100.00%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adriancable commented 11 months ago

This looks good to me, although I would like another pair of eyes on it as a sanity check before merging. @cnderrauber / @davidzhao / @Sean-Der ?

adriancable commented 11 months ago

@minlp - can you take a look at @davidzhao's comment and push a change to your fork if needed? Then I think we can get this merged.

minlp commented 11 months ago

@minlp - can you take a look at @davidzhao's comment and push a change to your fork if needed? Then I think we can get this merged.

I have already updated the code on the fix_dtls_flight1parse_except branch.@adriancable

adriancable commented 11 months ago

@minlp - ok great. Please squash the commit (you can retain the original title, “Fix flight1parse processing exception) and then assuming all checks are passed I will merge. Thank you!