search

pion / dtls

DTLS 1.2 Server/Client implementation for Go
https://pion.ly/
MIT License
604 stars 158 forks source link

Add support for MKI in use_srtp #660

Closed Sean-Der closed 3 months ago

Sean-Der commented 3 months ago

Resolves #650

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.22%. Comparing base (7139e0e) to head (770725c).

Files Patch % Lines
flight4bhandler.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #660 +/- ## ========================================== + Coverage 80.13% 80.22% +0.08% ========================================== Files 101 101 Lines 5317 5335 +18 ========================================== + Hits 4261 4280 +19 - Misses 687 688 +1 + Partials 369 367 -2 ``` | [Flag](https://app.codecov.io/gh/pion/dtls/pull/660/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/dtls/pull/660/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `80.25% <91.66%> (+0.08%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/dtls/pull/660/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `64.29% <91.66%> (+0.45%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sean-Der commented 3 months ago

@sirzooro Would you mind checking if this works for you? If you are happy with it can you approve and merge

thank you :)

Sean-Der commented 3 months ago

@daenney It would be nice! Especially when it is time to do DTLS v1.3

sirzooro commented 3 months ago

Thanks! I have just returned from vacation and saw this PR. Changes looks good for me. I will test them now. I will open new issue if I find that something does not work as expected.