search

pion / example-webrtc-applications

Examples of WebRTC applications that are large, or use 3rd party libraries
https://pion.ly/
MIT License
1.05k stars 248 forks source link

Only send PLIs for video tracks #228

Closed tmatth closed 2 months ago

tmatth commented 2 months ago

Description

The existing examples were sending them for audio and video.

tmatth commented 2 months ago

I can also split this up into one commit per example if that's preferable.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c3ff511) to head (c6c5ba4). Report is 1 commits behind head on master.

Files Patch % Lines
gstreamer-receive/main.go 0.00% 7 Missing :warning:
save-to-webm/main.go 0.00% 7 Missing :warning:
snapshot/main.go 0.00% 7 Missing :warning:
twitch/main.go 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #228 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 27 27 Lines 2068 2072 +4 ====================================== - Misses 2068 2072 +4 ``` | [Flag](https://app.codecov.io/gh/pion/example-webrtc-applications/pull/228/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/example-webrtc-applications/pull/228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `0.00% <0.00%> (ø)` | | | [wasm](https://app.codecov.io/gh/pion/example-webrtc-applications/pull/228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `0.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.