pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
430 stars 158 forks source link

Allow using mDNS candidates with UDP multiplexing #634

Closed Aleksbgbg closed 5 months ago

Aleksbgbg commented 8 months ago

Description

The UDP mux code path for gathering candidates is different from the main path in that it doesn't take the mDNS setting into account. This pull request fixes the issue.

In the future, we should look into sharing the code as much as possible between the code paths to avoid having to duplicate the logic (and therefore inadvertently making mistakes).

Sean-Der commented 5 months ago

Thank you so much @Aleksbgbg I cherry-picked with a72844663f279caa422e97ae760509d8916bc708

Do you have any interest in fixing the duplicate logic? I would love to see things improved :) I haven't had a chance to look at that recently though