search

pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
430 stars 158 forks source link

Trace log inbound messages #641

Closed boks1971 closed 8 months ago

boks1971 commented 8 months ago

On an ICE restart in controlled mode, seeing incoming messages getting discarded to due to username mismatch. That is because the broswer is still using its old candidate and user name. As the controlled agent waits for useCandidate from the controlling agent, the controlled agent does not get to connected/nominated state inspite of getting several success responses. Suspect the controlling side does not have useCandidate for the new pair and it is still sending it for the old pair. Logging more details in trace to understand it better.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (df552cd) 78.60% compared to head (05856b0) 78.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #641 +/- ## ========================================== + Coverage 78.60% 78.62% +0.02% ========================================== Files 42 42 Lines 4394 4394 ========================================== + Hits 3454 3455 +1 + Misses 726 724 -2 - Partials 214 215 +1 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/641/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `78.62% <100.00%> (+0.02%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/ice/pull/641/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `22.36% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

boks1971 commented 8 months ago

Unsure what is causing all the CI failures. Happens on a local run too. Did not expect my changes to produce that. Will dig.

boks1971 commented 8 months ago

oh, the tests are comparing string versions of the pairs.

Need to enhance tests or figure out a way to log differently.