search

pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
430 stars 158 forks source link

Start the listening port by default above 1024 #651

Closed dirkx closed 5 months ago

dirkx commented 7 months ago

Summary

Given of often users of ICE may run at non priveleged users - it may make sense to make the 'port min' default in https://github.com/pion/ice/blob/ab18a94710c2fd279759ade01f19fc1f0e775af1/net.go#L109

from 1 to the unprivileged 1024

Motivation

Easy of use

Describe alternatives you've considered

One can explicitly configure this - so pure nice to have.

Sean-Der commented 7 months ago

@dirkx Sounds good to me! Mind making a PR?