pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
430 stars 158 forks source link

Avoid priv. ports #652

Closed dirkx closed 5 months ago

dirkx commented 6 months ago

Description

Avoid the priveleged port range when selecting a port to listen/bind to.

Reference issue

Fixes #651

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ab18a94) 78.60% compared to head (ab78216) 78.76%.

Files Patch % Lines
net.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #652 +/- ## ========================================== + Coverage 78.60% 78.76% +0.15% ========================================== Files 42 42 Lines 4394 4394 ========================================== + Hits 3454 3461 +7 + Misses 725 719 -6 + Partials 215 214 -1 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/652/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/652/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `78.76% <0.00%> (+0.15%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/ice/pull/652/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `22.36% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sean-Der commented 5 months ago

Cherry-picked as 970978e8c79a2d68234ff1e85b655dbde0b090c9 thank you @dirkx

Just had to fix a typo in the comment to pass CI