pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
430 stars 158 forks source link

Ensure sequential execution of connection state callbacks #656

Closed sukunrt closed 5 months ago

sukunrt commented 6 months ago

Ice update connection state callbacks need to happen sequentially otherwise a later callback could overwrite a newer callback.

Fixes: #624

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.89%. Comparing base (77cc354) to head (59cc806).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #656 +/- ## ========================================== + Coverage 78.84% 78.89% +0.04% ========================================== Files 42 42 Lines 4444 4454 +10 ========================================== + Hits 3504 3514 +10 Misses 722 722 Partials 218 218 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/656/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/656/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `78.89% <100.00%> (+0.04%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/ice/pull/656/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `23.57% <90.90%> (+0.40%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.