Closed edaniels closed 5 months ago
@edaniels Would it possible to limit this just to mDNS for now?
I would love to see these other things fixed, but as unique efforts/PRs.
The
Mux
setup in ICE in particular needs evaluated. We have 3 different UDP Mux's I believe, and they all have different issues. Before we break any APIs I would like to understand them all and do one clean break!
I want to say yes but let's see what breaks when I undo those changes in this PR. They must have happened in combination with a TCP mux plus mDNS tests. If they don't break, I'll keep it undone. If they do, I'll see if I can create a temporary hidden interface that is an experimental API that works for the mixed implemented in the pkg!
Attention: Patch coverage is 74.13333%
with 97 lines
in your changes are missing coverage. Please review.
Project coverage is 78.75%. Comparing base (
ae1ba6f
) to head (8af8f9c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@edaniels Would it possible to limit this just to mDNS for now?
I would love to see these other things fixed, but as unique efforts/PRs.
The
Mux
setup in ICE in particular needs evaluated. We have 3 different UDP Mux's I believe, and they all have different issues. Before we break any APIs I would like to understand them all and do one clean break!