search

pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
424 stars 158 forks source link

Support IPv6 from mDNS #660

Closed edaniels closed 5 months ago

Sean-Der commented 5 months ago

@edaniels Would it possible to limit this just to mDNS for now?

I would love to see these other things fixed, but as unique efforts/PRs.

The Mux setup in ICE in particular needs evaluated. We have 3 different UDP Mux's I believe, and they all have different issues. Before we break any APIs I would like to understand them all and do one clean break!

edaniels commented 5 months ago

@edaniels Would it possible to limit this just to mDNS for now?

I would love to see these other things fixed, but as unique efforts/PRs.

The Mux setup in ICE in particular needs evaluated. We have 3 different UDP Mux's I believe, and they all have different issues. Before we break any APIs I would like to understand them all and do one clean break!

I want to say yes but let's see what breaks when I undo those changes in this PR. They must have happened in combination with a TCP mux plus mDNS tests. If they don't break, I'll keep it undone. If they do, I'll see if I can create a temporary hidden interface that is an experimental API that works for the mixed implemented in the pkg!

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 74.13333% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 78.75%. Comparing base (ae1ba6f) to head (8af8f9c).

Files Patch % Lines
gather.go 62.16% 21 Missing and 7 partials :warning:
addr.go 63.01% 20 Missing and 7 partials :warning:
agent.go 65.78% 7 Missing and 6 partials :warning:
mdns.go 78.18% 9 Missing and 3 partials :warning:
candidate_base.go 72.72% 2 Missing and 1 partial :warning:
candidate_host.go 75.00% 1 Missing and 1 partial :warning:
candidate_peer_reflexive.go 60.00% 1 Missing and 1 partial :warning:
candidate_relay.go 85.71% 1 Missing and 1 partial :warning:
candidate_server_reflexive.go 85.71% 1 Missing and 1 partial :warning:
net.go 94.73% 1 Missing and 1 partial :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #660 +/- ## ========================================== + Coverage 78.56% 78.75% +0.19% ========================================== Files 42 42 Lines 4487 4698 +211 ========================================== + Hits 3525 3700 +175 - Misses 740 767 +27 - Partials 222 231 +9 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/660/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/660/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `78.75% <74.13%> (+0.19%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/ice/pull/660/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `22.48% <14.93%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.