Closed stephanrotolante closed 4 months ago
Nice! This looks perfect to me @stephanrotolante
When all the tests go green go ahead and merge!
Then in https://github.com/pion/ice/releases/new create v3.0.4
and do Generate release notes
. Then you can open up a pion/webrtc
PR and add it to the SettingEngine.
Attention: Patch coverage is 57.14286%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 78.65%. Comparing base (
a12f670
) to head (d47c426
).
Files | Patch % | Lines |
---|---|---|
agent_config.go | 40.00% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Allows to configure STUN timeout from the config
Reference issue
Resolves https://github.com/pion/webrtc/issues/2668