Closed paralin closed 4 months ago
Nice catch! Do we have this problem anywhere else?
I will add this check to CI
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.15%. Comparing base (
fd4b1f8
) to head (4272dcf
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
After applying this PR I don't see any other reference to testify in my project's build which also imports the main webrtc packages. So, I think this is probably the only case where that happened.
I noticed that the pion-ice package had ~1MB of extra binary size due to the dependency on stretchr/testify.
Renaming test_utils.go to utils_test.go removes stretchr/testify from any non-test build and fixes this dependency. The tests still pass & the package still builds the same.
One can check the dependency graph with goda:
https://github.com/loov/goda
goda graph "reach(.:all, github.com/stretchr/testify/require)" | dot -Tsvg -o graph.svg