pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
424 stars 158 forks source link

Reuse connectivity check ticker #676

Closed paulwe closed 4 months ago

paulwe commented 4 months ago

we're seeing high runtime.siftdownTimer cpu on some busy nodes and profiling indicates there are ~20k timers allocated here. recreating these on every loop is inefficient.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.17%. Comparing base (0860817) to head (3768593).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #676 +/- ## ========================================== + Coverage 79.07% 79.17% +0.09% ========================================== Files 41 41 Lines 3738 3740 +2 ========================================== + Hits 2956 2961 +5 + Misses 549 547 -2 + Partials 233 232 -1 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/676/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/676/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `79.17% <100.00%> (+0.09%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/ice/pull/676/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `22.12% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.