pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
424 stars 158 forks source link

Add network to resolve stun host error message #678

Closed kparadis closed 4 months ago

kparadis commented 4 months ago

Description

Most error message in gatherCandidatesSrflx and gatherCandidatesSrflxUDPMux include the network in them but not the one when failing to Resolve the host.

Reference issue

Fixes #...

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 22.12%. Comparing base (0062167) to head (4bd6700). Report is 1 commits behind head on master.

Files Patch % Lines
gather.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #678 +/- ## =========================================== - Coverage 79.11% 22.12% -57.00% =========================================== Files 41 40 -1 Lines 3740 3734 -6 =========================================== - Hits 2959 826 -2133 - Misses 548 2866 +2318 + Partials 233 42 -191 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/678/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/678/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `?` | | | [wasm](https://app.codecov.io/gh/pion/ice/pull/678/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `22.12% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sean-Der commented 4 months ago

Thank you so much @kparadis

Always excited to see 'First time contributor' on the PR :)

Hope you stay involved. If you have any ideas on how to improve Pion I would love to hear