pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
424 stars 158 forks source link

[Cherrypick] Improve STUN resolution error message #679

Closed MaximeBdrd closed 2 weeks ago

MaximeBdrd commented 4 months ago

Cherrypick from master branch (we will keep using the v2 for some time) Add network to resolve stun host error message

Description

Most error message in gatherCandidatesSrflx and gatherCandidatesSrflxUDPMux include the network in them but not the one when failing to Resolve the host.

Reference issue

Will help troubleshooting problems in the field

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (v2@62795f0). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2 #679 +/- ## ===================================== Coverage ? 79.49% ===================================== Files ? 42 Lines ? 3667 Branches ? 0 ===================================== Hits ? 2915 Misses ? 538 Partials ? 214 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/679/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/679/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `79.49% <100.00%> (?)` | | | [wasm](https://app.codecov.io/gh/pion/ice/pull/679/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `23.45% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.