pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
424 stars 158 forks source link

Return io.EOF from closed udpMuxedConn #692

Closed paulwe closed 4 months ago

paulwe commented 4 months ago

write returns io.ErrClosedPipe but read returns io.EOF...

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.15%. Comparing base (edb6929) to head (68a02a4).

Files Patch % Lines
udp_muxed_conn.go 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #692 +/- ## ========================================== - Coverage 79.21% 79.15% -0.06% ========================================== Files 41 41 Lines 3733 3733 ========================================== - Hits 2957 2955 -2 - Misses 547 548 +1 - Partials 229 230 +1 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/692/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `79.15% <50.00%> (-0.06%)` | :arrow_down: | | [wasm](https://app.codecov.io/gh/pion/ice/pull/692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `22.16% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.