pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
424 stars 158 forks source link

Add BindingRequestHandler #695

Closed Sean-Der closed 4 months ago

Sean-Der commented 4 months ago

Allow the user to perform custom processing for inbound STUN Binding requests. This allows users to do some of the following

Resolves pion/webrtc#2539 Resolves pion/webrtc#2585 Resolves #623

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.19%. Comparing base (b5f4ca0) to head (74830a2).

Files Patch % Lines
selection.go 77.77% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #695 +/- ## ========================================== + Coverage 79.13% 79.19% +0.05% ========================================== Files 41 41 Lines 3734 3739 +5 ========================================== + Hits 2955 2961 +6 + Misses 549 547 -2 - Partials 230 231 +1 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/695/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/695/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `79.19% <77.77%> (+0.05%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/ice/pull/695/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `22.13% <0.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.