search

pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
424 stars 158 forks source link

Fix Callback ordering for ConnectionState #702

Closed sukunrt closed 2 months ago

sukunrt commented 2 months ago

This is already fixed on master. I've cherry picked 2 commits: https://github.com/pion/ice/commit/d17be4df3b49c712adf6c2c9ab08a5c4c87676f5 & https://github.com/pion/ice/commit/67cc918a518d3b3dd1887b07434331dabc846702

Since pion/webrtc/v3 depends on pion/ice/v2 it'd be nice if we can have a v2 release with these two commits.

Sean-Der commented 2 months ago

LGTM!

I’m a week out from new version of DTLS. New major version of WebRTC is next.

excited to get off old versions

sukunrt commented 2 months ago

Thanks @Sean-Der. Looking forward to webrtc v4. :tada:

sukunrt commented 2 months ago

@Sean-Der Can I merge this and cut a new release?

Sean-Der commented 2 months ago

Go for it @sukunrt ! Thanks for doing it :)