pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
424 stars 158 forks source link

Remove IPv6 ZoneID from ICE candidates #704

Closed sirzooro closed 1 month ago

sirzooro commented 2 months ago

Link-local IPv6 addresses may have ZoneID attached at the end. It has local meaning only and should not be send to other parties. This change removes ZoneID from generated candidate string, and ignores ZoneID when received candidate is parsed.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.20%. Comparing base (d8341e7) to head (de0a63a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #704 +/- ## ========================================== + Coverage 79.13% 79.20% +0.07% ========================================== Files 41 41 Lines 3771 3775 +4 ========================================== + Hits 2984 2990 +6 + Misses 556 555 -1 + Partials 231 230 -1 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/704/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `79.20% <100.00%> (+0.07%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/ice/pull/704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `22.47% <100.00%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.