Closed edaniels closed 1 month ago
Attention: Patch coverage is 75.00000%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 79.07%. Comparing base (
2a9fdb5
) to head (72c7732
).
Files | Patch % | Lines |
---|---|---|
agent_handlers.go | 67.85% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@paulwe tagging you on this as it closely matches with your initial comments about not leaving behind rogue goroutines
This ensures no goroutines are running when an ICE agent closes. I'd also like to backport this into v2 so that webrtc/v3 can get it.