pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
424 stars 158 forks source link

Remove IPv6 ZoneID from ICE candidates (#704) #707

Closed sirzooro closed 1 month ago

sirzooro commented 1 month ago

Link-local IPv6 addresses may have ZoneID attached at the end. It has local meaning only and should not be send to other parties. This change removes ZoneID from generated candidate string, and ignores ZoneID when received candidate is parsed.

It is already merged to master, this cherry-pick is for v2.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (v2@822108b). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2 #707 +/- ## ===================================== Coverage ? 79.72% ===================================== Files ? 42 Lines ? 3650 Branches ? 0 ===================================== Hits ? 2910 Misses ? 526 Partials ? 214 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/707/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/707/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `79.72% <100.00%> (?)` | | | [wasm](https://app.codecov.io/gh/pion/ice/pull/707/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `23.53% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.