pion / ice

A Go implementation of ICE
https://pion.ly/
MIT License
454 stars 160 forks source link

Add test that NetworkTypes is respected #722

Closed Sean-Der closed 3 months ago

Sean-Der commented 3 months ago

Assert that a remote Passive TCP candidate doesn't cause a TCP connection to be started.

Resolves pion/webrtc#2782

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.11%. Comparing base (3051b4a) to head (b559a79). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #722 +/- ## ======================================= Coverage 79.11% 79.11% ======================================= Files 41 41 Lines 3782 3782 ======================================= Hits 2992 2992 Misses 558 558 Partials 232 232 ``` | [Flag](https://app.codecov.io/gh/pion/ice/pull/722/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/ice/pull/722/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `79.11% <ø> (ø)` | | | [wasm](https://app.codecov.io/gh/pion/ice/pull/722/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `22.46% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.