codecov[bot]
commented
11 months ago Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.
| Files | Coverage Δ | |
|---|---|---|
| pkg/nack/generator_interceptor.go | 67.17% <0.00%> (-1.05%) |
:arrow_down: |
... and 1 file with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.
Following PR #208, the NACK generator interceptor may send NACK RTCP packets even if there are no missing packets to NACK (specifically if the receive log indicates missing packets, but we've already hit the NACK send limit for those so do not need to NACK those any further). This is functionally 'harmless' but wastes link bandwidth. This PR skips sending a NACK RTCP packet if there are no packets to NACK.