[FlexFec] Adding support for FlexFec RFC-03

pougetat commented 8 months ago

This PR is part of a series of PRs to provide FlexFec support for pion. https://datatracker.ietf.org/doc/html/rfc8627

This PR provides the following:

Adding a FlexFec encoder implementation for https://datatracker.ietf.org/doc/html/draft-ietf-payload-flexible-fec-scheme-03 => This is the implementation that chromium currently uses instead of the latest version of the draft. Providing support for this draft version will enable pion to work with chromium-based browsers.
Changing the FEC coverage data structure to use 2 uint64 to store the packet masks. This will reduce allocations.
Adding support for the actual Interceptor component that batches RTP packets together to generate repair packets before sending both types of packets over the network.
Various fixes to FEC header encoding, validated with chromium.

There are still some issues to be tackled:

Hardcoded timestamp for the RTP header. Chromium seems to work just fine with this but we need to properly set this value.
We currently limit ourselves to VP8, FlexFec is meant to be codec agnostic so we can provide support for more codecs.
We currently hardcode a minimum of 5 media packets protected by 2 media packets, this should be configurable.
We need to account for missing media packets, indeed media packets could be dropped on the way to being received by pion, and our FEC encoder assumes there are no missing media packets.

Fixes #...

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!.

SerialVelocity commented 5 months ago

Hey @pougetat, does this only work for Opus (since it has inbandfec=1) or will it work for VP8, etc as well? I saw that the (Chrome) SDP has:

a=rtpmap:49 flexfec-03/90000
a=rtcp-fb:49 goog-remb
a=rtcp-fb:49 transport-cc
a=fmtp:49 repair-window=10000000

I'm assuming that means that flexfec-03 has to be sent over 49 instead of something like 96 or am I misunderstanding something?

Is this interceptor plug and play or do I need to set up extra lines in the SDP/RTCPFeedback/etc?