search

pion / interceptor

Pluggable RTP/RTCP processors for building real time communication
https://pion.ly/
MIT License
104 stars 51 forks source link

JitterBuffer: Interceptor #247

Closed thatsnotright closed 2 months ago

thatsnotright commented 2 months ago

Description

This implements a RemoteStream jitter buffer interceptor.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 82.25806% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 72.14%. Comparing base (1449b4f) to head (6d74945). Report is 1 commits behind head on master.

Files Patch % Lines
pkg/jitterbuffer/receiver_interceptor.go 73.17% 8 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #247 +/- ## ========================================== + Coverage 72.08% 72.14% +0.06% ========================================== Files 77 79 +2 Lines 3582 3644 +62 ========================================== + Hits 2582 2629 +47 - Misses 866 876 +10 - Partials 134 139 +5 ``` | [Flag](https://app.codecov.io/gh/pion/interceptor/pull/247/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/interceptor/pull/247/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `72.14% <82.25%> (+0.06%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/interceptor/pull/247/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `70.30% <79.03%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thatsnotright commented 2 months ago

@Sean-Der I'm not sure why the nack test failed for WASM this run but not others. I think this PR is close to ready but I'd like to see what else you think it needs?

dryarullin commented 2 months ago

@thatsnotright Could you look at my issue please?