search

pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
540 stars 123 forks source link

Update webcam module to set the camera framerate #390

Closed f-fl0 closed 2 years ago

f-fl0 commented 2 years ago

Description

This PR updates the webcam module to ba064708e1652773bdb71e0605a1819ef4fad2e7 which allows to set (and get) the video camera capture framerate based on the FrameRate value specified in prop.Media.

codecov[bot] commented 2 years ago

Codecov Report

Merging #390 (a21eab0) into master (7026126) will decrease coverage by 0.04%. The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   47.16%   47.12%   -0.05%     
==========================================
  Files          67       67              
  Lines        4380     4386       +6     
==========================================
+ Hits         2066     2067       +1     
- Misses       2189     2194       +5     
  Partials      125      125
Impacted Files Coverage Δ
pkg/driver/camera/camera_linux.go 26.31% <0.00%> (-0.80%) :arrow_down:
pkg/prop/prop.go 72.10% <100.00%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7026126...a21eab0. Read the comment docs.

f-fl0 commented 2 years ago

15973f6961cbe56d44372d74f46abe88598265a1 failed in CI because of the following error:

=== RUN   TestThrottle
    throttle_test.go:36: Number of pushed images is expected to be 20, but pushed 27
--- FAIL: TestThrottle (0.54s)
FAIL

It seems irrelevant to the changes introduced in this PR.