search

pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
540 stars 123 forks source link

Remove video framerate as explicit constraint #394

Closed f-fl0 closed 2 years ago

f-fl0 commented 2 years ago

Description

This PR addresses an issue introduced by changes from https://github.com/pion/mediadevices/pull/390: the video framerate was added as an explicit constraint to find a compatible driver. As camera.Properties currently does not have access to the list of available framerate no driver can be matched. Until this information can be retrieved it is better to not include the framerate in the fitness function. As a workaround, when a framerate is specified (i.e. > 0), a comparison between the desired value and the one reported by the device is performed and an error is returned when they are not equal.

codecov[bot] commented 2 years ago

Codecov Report

Merging #394 (782d02e) into master (e780bdc) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   47.11%   47.15%   +0.03%     
==========================================
  Files          67       67              
  Lines        4387     4390       +3     
==========================================
+ Hits         2067     2070       +3     
  Misses       2195     2195              
  Partials      125      125
Impacted Files Coverage Δ
pkg/prop/prop.go 72.66% <100.00%> (+0.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e780bdc...782d02e. Read the comment docs.