search

pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
540 stars 123 forks source link

Enable configuration of OpenH264 Encoder #409

Closed adamroach closed 2 years ago

adamroach commented 2 years ago

Description

There's been a long-standing TODO comment in the bridge for OpenH264 to remove hardcoding for the set of configurable parameters exposed by that library. That patch does exactly that.

codecov[bot] commented 2 years ago

Codecov Report

Merging #409 (aec15ac) into master (5b99500) will increase coverage by 0.21%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   47.23%   47.45%   +0.21%     
==========================================
  Files          67       67              
  Lines        4401     4419      +18     
==========================================
+ Hits         2079     2097      +18     
  Misses       2197     2197              
  Partials      125      125
Impacted Files Coverage Δ
pkg/codec/openh264/openh264.go 76.81% <100.00%> (+3.47%) :arrow_up:
pkg/codec/openh264/params.go 89.47% <100.00%> (+9.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b99500...aec15ac. Read the comment docs.