search

pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
528 stars 121 forks source link

rename opus C function to be compatible with other opus modules #425

Closed EmrysMyrddin closed 2 years ago

EmrysMyrddin commented 2 years ago

Description

Renaming the C bitrate setter function allow to be combatible with gopkg.in/hraban/opus.v2 (an opus decoder package)

Reference issue

Fixes #362

codecov[bot] commented 2 years ago

Codecov Report

Merging #425 (4ccb577) into master (416bbc3) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   47.32%   47.32%           
=======================================
  Files          67       67           
  Lines        4463     4463           
=======================================
  Hits         2112     2112           
  Misses       2226     2226           
  Partials      125      125
Impacted Files Coverage Δ
pkg/codec/opus/opus.go 65.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 416bbc3...4ccb577. Read the comment docs.

at-wat commented 2 years ago

Maybe better to add pion/mediadevices specific prefix to cgo functions to avoid any other name conflicts?

EmrysMyrddin commented 2 years ago

I agree, was not sure if it was a good idea ^^'