pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
521 stars 120 forks source link

Update libopus static library to correct arch for darwin arm64 #428

Closed edaniels closed 1 year ago

edaniels commented 1 year ago

See https://github.com/pion/mediadevices/pull/368#issuecomment-1114623571

codecov[bot] commented 1 year ago

Codecov Report

Merging #428 (72b8f50) into master (3bcbed0) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   47.32%   47.32%           
=======================================
  Files          67       67           
  Lines        4463     4463           
=======================================
  Hits         2112     2112           
  Misses       2226     2226           
  Partials      125      125           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sean-Der commented 1 year ago

@edaniels This is just removing, did you also intend to add the correct one?

thanks for opening this PR!

edaniels commented 1 year ago

@Sean-Der It's a modification! Curious that it's not an add and remove since it's binary.

at-wat commented 1 year ago

@edaniels Could you update https://github.com/pion/mediadevices/blob/master/dockerfiles/darwin-arm64.cmake https://github.com/pion/mediadevices/blob/master/dockerfiles/darwin-arm64.Dockerfile to make it cross-compilable? All other static libraries are built by the scripts in https://github.com/pion/mediadevices/tree/master/dockerfiles and it's very hard to be maintained in the future without cross-compilation.

edaniels commented 1 year ago

I did this via the make target so there's no changes to make. It looks like the wrong file was originally committed :)

at-wat commented 1 year ago

Is pkg/codec/openh264/lib/libopenh264-darwin-arm64.a incorrect as well?

edaniels commented 1 year ago

lookin good 8)

Non-fat file: ./pkg/codec/openh264/lib/libopenh264-darwin-arm64.a is architecture: arm64
Non-fat file: ./pkg/codec/openh264/lib/libopenh264-darwin-x64.a is architecture: x86_64