pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
521 stars 120 forks source link

Add missing EnablePictureID in VP8Payloader #453

Open vpalmisano opened 1 year ago

vpalmisano commented 1 year ago

The EnablePictureID param is required to create the extended RTP VP8 header. Without this header the VP8 streams cannot be read by the Mediasoup SFU.

Description

Reference issue

codecov[bot] commented 1 year ago

Codecov Report

Base: 58.15% // Head: 58.15% // No change to project coverage :thumbsup:

Coverage data is based on head (f1704d1) compared to base (09f3bcc). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #453 +/- ## ======================================= Coverage 58.15% 58.15% ======================================= Files 62 62 Lines 3680 3680 ======================================= Hits 2140 2140 Misses 1413 1413 Partials 127 127 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.