pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
535 stars 122 forks source link

Fix for preventing close of stopRead nil channel #458

Closed malykhin closed 1 year ago

malykhin commented 1 year ago

Description

The behaviour is described here: https://github.com/pion/mediadevices/issues/457 The issue is opened for Windows, but it occurs on Raspbian as well. Can't reproduce it on macOS. Noticed this issue after migrating mediadevices from v0.3.7 to v0.3.10

Reference issue

Fixes #457

codecov[bot] commented 1 year ago

Codecov Report

Base: 58.15% // Head: 58.16% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (d6925fd) compared to base (cb23f1f). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #458 +/- ## ========================================== + Coverage 58.15% 58.16% +0.01% ========================================== Files 62 62 Lines 3680 3679 -1 ========================================== Hits 2140 2140 + Misses 1413 1412 -1 Partials 127 127 ``` | [Impacted Files](https://codecov.io/gh/pion/mediadevices/pull/458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [track.go](https://codecov.io/gh/pion/mediadevices/pull/458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#diff-dHJhY2suZ28=) | `25.31% <0.00%> (+0.07%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.