Closed bazile-clyde closed 1 year ago
Do you think we can expose setup function in other drivers as well? It would be better to have unified interface to update device list.
Base: 58.16% // Head: 58.21% // Increases project coverage by +0.04%
:tada:
Coverage data is based on head (
b4118d2
) compared to base (6ac1424
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Do you think we can expose setup function in other drivers as well? It would be better to have unified interface to update device list.
@at-wat Done! I skipped the dummy.go
files in audiotest
and videotest
. I also skipped vncdriver.go
since there's no func init
. Let me know if I should not have skipped any of those.
@bazile-clyde thanks!
I think it would be better in future to have another API that mediadevices.MediaDevices
can automatically call them to update the device list.
For this, Initialize
functions would be better to have godoc comments to mention this API is experimental.
What do you think?
@bazile-clyde thanks!
I think it would be better in future to have another API that
mediadevices.MediaDevices
can automatically call them to update the device list. For this,Initialize
functions would be better to have godoc comments to mention this API is experimental. What do you think?
That makes sense. I don't have strong opinions either way so I added it. Thanks for the quick turn-around btw!
Could you revert import block orders to keep them like
import ( "stdlib1" "stdlib2" "nonstdlib1" "nonstdlib2" )
Done!
Description
This PR exports the logic executed at startup to find and register cameras. This will allow us to discover cameras connected after our application has started.